Skip to content

feat(tke): [116855855]add tencentcloud_kubernetes_addon #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2024

Conversation

lyu571
Copy link
Contributor

@lyu571 lyu571 commented May 9, 2024

No description provided.

@lyu571 lyu571 changed the title Feat/add tke addon feat(tke): [116855855]add tencentcloud_kubernetes_addon May 9, 2024
@lyu571 lyu571 added the run check run check label May 10, 2024
@lyu571
Copy link
Contributor Author

lyu571 commented May 10, 2024

image

Steps: []resource.TestStep{{
Config: testAccKubernetesAddon,
Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_kubernetes_addon.kubernetes_addon", "id"),
resource.TestCheckResourceAttr("tencentcloud_kubernetes_addon.kubernetes_addon", "addon_name", "cos"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不支持修改吗,没有看到修改的测试用例

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

支持修改的,等我补充一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改了。
image

@lyu571 lyu571 changed the title feat(tke): [116855855]add tencentcloud_kubernetes_addon [先不合入]feat(tke): [116855855]add tencentcloud_kubernetes_addon May 10, 2024
@lyu571 lyu571 changed the title [先不合入]feat(tke): [116855855]add tencentcloud_kubernetes_addon feat(tke): [116855855]add tencentcloud_kubernetes_addon May 11, 2024
@lyu571 lyu571 added run check run check and removed run check run check labels May 11, 2024
Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 2a33120 into master May 11, 2024
9 of 10 checks passed
@andrew-tx andrew-tx deleted the feat/tke-addon branch May 11, 2024 14:23
hellertang pushed a commit that referenced this pull request May 21, 2024
* feat(tke): [116855855]add tencentcloud_kubernetes_addon

* add doc

* 1.adjust format. 2.add changelog

* resolve conflict

* 1.add base64 support. 2.add update e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants